From 0812901745b98a6cb26ea4ad632a023a46106312 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Sat, 18 Nov 2017 05:46:19 +0100
Subject: [PATCH] Various code cleanup.

---
 app/Exceptions/Handler.php                        | 2 ++
 app/Http/Controllers/Auth/LoginController.php     | 3 +++
 app/Http/Controllers/Json/FrontpageController.php | 2 ++
 app/Http/Controllers/NewUserController.php        | 6 ++++--
 app/Http/Controllers/ProfileController.php        | 1 +
 app/Http/Controllers/TransactionController.php    | 3 ++-
 app/Repositories/Journal/JournalRepository.php    | 1 +
 7 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
index 322ae31e26..02e1670b03 100644
--- a/app/Exceptions/Handler.php
+++ b/app/Exceptions/Handler.php
@@ -85,6 +85,8 @@ class Handler extends ExceptionHandler
      * @SuppressWarnings(PHPMD.CyclomaticComplexity) // it's five its fine.
      *
      * @param \Exception $exception
+     *
+     * @return mixed|void
      */
     public function report(Exception $exception)
     {
diff --git a/app/Http/Controllers/Auth/LoginController.php b/app/Http/Controllers/Auth/LoginController.php
index 1a4aa09918..c826709f8f 100644
--- a/app/Http/Controllers/Auth/LoginController.php
+++ b/app/Http/Controllers/Auth/LoginController.php
@@ -74,6 +74,9 @@ class LoginController extends Controller
     /**
      * Show the application's login form.
      *
+     * @param Request   $request
+     * @param CookieJar $cookieJar
+     *
      * @return \Illuminate\Http\Response
      */
     public function showLoginForm(Request $request, CookieJar $cookieJar)
diff --git a/app/Http/Controllers/Json/FrontpageController.php b/app/Http/Controllers/Json/FrontpageController.php
index 4f187f4eab..c0390c6ffd 100644
--- a/app/Http/Controllers/Json/FrontpageController.php
+++ b/app/Http/Controllers/Json/FrontpageController.php
@@ -33,6 +33,8 @@ use Response;
 class FrontpageController extends Controller
 {
     /**
+     * @param PiggyBankRepositoryInterface $repository
+     *
      * @return \Illuminate\Http\JsonResponse
      */
     public function piggyBanks(PiggyBankRepositoryInterface $repository)
diff --git a/app/Http/Controllers/NewUserController.php b/app/Http/Controllers/NewUserController.php
index 6589f22769..d1f9df1556 100644
--- a/app/Http/Controllers/NewUserController.php
+++ b/app/Http/Controllers/NewUserController.php
@@ -70,8 +70,10 @@ class NewUserController extends Controller
     }
 
     /**
-     * @param NewUserFormRequest         $request
-     * @param AccountRepositoryInterface $repository
+     * @param NewUserFormRequest          $request
+     * @param AccountRepositoryInterface  $repository
+     *
+     * @param CurrencyRepositoryInterface $currencyRepository
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      */
diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php
index c8fe9ed92e..0ee347e9fb 100644
--- a/app/Http/Controllers/ProfileController.php
+++ b/app/Http/Controllers/ProfileController.php
@@ -260,6 +260,7 @@ class ProfileController extends Controller
      * @param string $token
      * @param string $hash
      *
+     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      * @throws FireflyException
      */
     public function undoEmailChange(string $token, string $hash)
diff --git a/app/Http/Controllers/TransactionController.php b/app/Http/Controllers/TransactionController.php
index ed2cf98897..47eb0e690e 100644
--- a/app/Http/Controllers/TransactionController.php
+++ b/app/Http/Controllers/TransactionController.php
@@ -126,7 +126,8 @@ class TransactionController extends Controller
     }
 
     /**
-     * @param Request $request
+     * @param Request                    $request
+     * @param JournalRepositoryInterface $repository
      */
     public function reconcile(Request $request, JournalRepositoryInterface $repository)
     {
diff --git a/app/Repositories/Journal/JournalRepository.php b/app/Repositories/Journal/JournalRepository.php
index 2e03e96231..c1b3fee1cc 100644
--- a/app/Repositories/Journal/JournalRepository.php
+++ b/app/Repositories/Journal/JournalRepository.php
@@ -264,6 +264,7 @@ class JournalRepository implements JournalRepositoryInterface
         $this->storeBudgetWithJournal($journal, $data['budget_id']);
 
         // store two transactions:
+
         $one = [
             'journal'                 => $journal,
             'account'                 => $accounts['source'],