From 5b8583dd2bd4f0d6b1773f501fcfb275fc9ca881 Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 7 Nov 2016 20:25:09 +0100 Subject: [PATCH] Make sure scripts don't crash when no database present. --- app/Console/Commands/UpgradeDatabase.php | 7 +++++++ app/Console/Commands/VerifyDatabase.php | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/app/Console/Commands/UpgradeDatabase.php b/app/Console/Commands/UpgradeDatabase.php index 2c1a4dee63..4d3633289f 100644 --- a/app/Console/Commands/UpgradeDatabase.php +++ b/app/Console/Commands/UpgradeDatabase.php @@ -20,6 +20,7 @@ use FireflyIII\Models\TransactionJournal; use Illuminate\Console\Command; use Illuminate\Database\QueryException; use Log; +use Schema; /** * Class UpgradeDatabase @@ -65,6 +66,12 @@ class UpgradeDatabase extends Command */ private function setTransactionIdentifier() { + // if table does not exist, return false + if (!Schema::hasTable('transaction_journals')) { + return; + } + + $subQuery = TransactionJournal ::leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id') ->whereNull('transaction_journals.deleted_at') diff --git a/app/Console/Commands/VerifyDatabase.php b/app/Console/Commands/VerifyDatabase.php index 6050902ecd..74668f4c24 100644 --- a/app/Console/Commands/VerifyDatabase.php +++ b/app/Console/Commands/VerifyDatabase.php @@ -26,6 +26,7 @@ use FireflyIII\Repositories\User\UserRepositoryInterface; use FireflyIII\User; use Illuminate\Console\Command; use Illuminate\Database\Eloquent\Builder; +use Schema; use stdClass; /** @@ -61,6 +62,11 @@ class VerifyDatabase extends Command */ public function handle() { + // if table does not exist, return false + if (!Schema::hasTable('users')) { + return; + } + // accounts with no transactions. $this->reportAccounts(); // budgets with no limits