Code cleanup.

This commit is contained in:
James Cole
2023-12-20 19:35:52 +01:00
parent c4f6366642
commit 64ec0cf62e
997 changed files with 12908 additions and 28136 deletions

View File

@@ -1,6 +1,5 @@
<?php
/*
* DestroyController.php
* Copyright (c) 2023 james@firefly-iii.org
@@ -40,9 +39,6 @@ class DestroyController extends Controller
{
private UserGroupRepositoryInterface $repository;
/**
*
*/
public function __construct()
{
parent::__construct();
@@ -55,11 +51,6 @@ class DestroyController extends Controller
);
}
/**
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function destroy(UserGroup $userGroup): JsonResponse
{
/** @var User $user */
@@ -71,6 +62,7 @@ class DestroyController extends Controller
throw new NotFoundHttpException();
}
$this->repository->destroy($userGroup);
return response()->json([], 204);
}
}

View File

@@ -1,6 +1,5 @@
<?php
/*
* ShowController.php
* Copyright (c) 2023 james@firefly-iii.org
@@ -40,9 +39,6 @@ class ShowController extends Controller
{
private UserGroupRepositoryInterface $repository;
/**
*
*/
public function __construct()
{
parent::__construct();
@@ -55,9 +51,6 @@ class ShowController extends Controller
);
}
/**
* @return JsonResponse
*/
public function index(): JsonResponse
{
$collection = new Collection();
@@ -78,14 +71,10 @@ class ShowController extends Controller
return response()
->json($this->jsonApiList('user-groups', $paginator, $transformer))
->header('Content-Type', self::CONTENT_TYPE);
->header('Content-Type', self::CONTENT_TYPE)
;
}
/**
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function show(UserGroup $userGroup): JsonResponse
{
$transformer = new UserGroupTransformer();
@@ -93,6 +82,7 @@ class ShowController extends Controller
return response()
->api($this->jsonApiObject('user-groups', $userGroup, $transformer))
->header('Content-Type', self::CONTENT_TYPE);
->header('Content-Type', self::CONTENT_TYPE)
;
}
}

View File

@@ -1,6 +1,5 @@
<?php
/*
* StoreController.php
* Copyright (c) 2023 james@firefly-iii.org
@@ -38,9 +37,6 @@ class StoreController extends Controller
{
private UserGroupRepositoryInterface $repository;
/**
*
*/
public function __construct()
{
parent::__construct();
@@ -53,11 +49,6 @@ class StoreController extends Controller
);
}
/**
* @param StoreRequest $request
*
* @return JsonResponse
*/
public function store(StoreRequest $request): JsonResponse
{
$all = $request->getAll();
@@ -67,7 +58,7 @@ class StoreController extends Controller
return response()
->api($this->jsonApiObject('user-groups', $userGroup, $transformer))
->header('Content-Type', self::CONTENT_TYPE);
->header('Content-Type', self::CONTENT_TYPE)
;
}
}

View File

@@ -1,6 +1,5 @@
<?php
/*
* UpdateController.php
* Copyright (c) 2023 james@firefly-iii.org
@@ -43,9 +42,6 @@ class UpdateController extends Controller
private UserGroupRepositoryInterface $repository;
/**
*
*/
public function __construct()
{
parent::__construct();
@@ -58,12 +54,6 @@ class UpdateController extends Controller
);
}
/**
* @param UpdateRequest $request
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function update(UpdateRequest $request, UserGroup $userGroup): JsonResponse
{
$all = $request->getAll();
@@ -73,15 +63,10 @@ class UpdateController extends Controller
return response()
->api($this->jsonApiObject('user-groups', $userGroup, $transformer))
->header('Content-Type', self::CONTENT_TYPE);
->header('Content-Type', self::CONTENT_TYPE)
;
}
/**
* @param UpdateMembershipRequest $request
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function updateMembership(UpdateMembershipRequest $request, UserGroup $userGroup): JsonResponse
{
$all = $request->getAll();
@@ -91,6 +76,7 @@ class UpdateController extends Controller
return response()
->api($this->jsonApiObject('user-groups', $userGroup, $transformer))
->header('Content-Type', self::CONTENT_TYPE);
->header('Content-Type', self::CONTENT_TYPE)
;
}
}