From 6fdfec39674a7ba49b6dc068cf032f1fac7d40c8 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Tue, 29 Mar 2016 16:13:36 +0200
Subject: [PATCH] Clean up some code.

---
 app/Http/Controllers/Chart/BudgetController.php | 5 +----
 app/Validation/FireflyValidator.php             | 2 +-
 tests/TestCase.php                              | 2 --
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/app/Http/Controllers/Chart/BudgetController.php b/app/Http/Controllers/Chart/BudgetController.php
index a02a94a1da..7452997d4c 100644
--- a/app/Http/Controllers/Chart/BudgetController.php
+++ b/app/Http/Controllers/Chart/BudgetController.php
@@ -310,7 +310,7 @@ class BudgetController extends Controller
         $cache->addProperty('budget');
         $cache->addProperty('year');
         if ($cache->has()) {
-            //return Response::json($cache->get()); // @codeCoverageIgnore
+            return Response::json($cache->get()); // @codeCoverageIgnore
         }
 
         $budgetInformation = $repository->getBudgetsAndExpensesPerMonth($accounts, $start, $end);
@@ -328,9 +328,6 @@ class BudgetController extends Controller
             $row           = [clone $start];
             $dateFormatted = $start->format('Y-m');
 
-            //echo $start,' '.$month.'<br>';
-
-
             // each budget, check if there is an entry for this month:
             /** @var array $row */
             foreach ($budgetInformation as $budgetRow) {
diff --git a/app/Validation/FireflyValidator.php b/app/Validation/FireflyValidator.php
index fffb7dc2e5..5cc51d0436 100644
--- a/app/Validation/FireflyValidator.php
+++ b/app/Validation/FireflyValidator.php
@@ -54,7 +54,7 @@ class FireflyValidator extends Validator
      *
      * @return bool
      */
-    public function validate2faCode($attribute, $value, $parameters): bool
+    public function validate2faCode($attribute, $value): bool
     {
         if (!is_string($value) || is_null($value) || strlen($value) <> 6) {
             return false;
diff --git a/tests/TestCase.php b/tests/TestCase.php
index a0245e08d8..95dfdb28bb 100644
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -36,8 +36,6 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase
             // set period to match?
 
         }
-        // custom is a weird range
-        // (20 days):
         if ($range === 'custom') {
             $this->session(
                 [