gh-mirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-10 12:24:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve test coverage and quality

Browse Source
This commit is contained in:
James Cole
2019-06-16 13:16:46 +02:00
parent 1ce1a84c9e
commit 72c0d7a874
34 changed files with 3211 additions and 2524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/Unit/Factory/AccountMetaFactoryTest.php
View File

@@ -25,6 +25,7 @@ namespace Tests\Unit\Factory;
use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Models\AccountMeta;
use Log;
use Tests\TestCase;
@@ -34,8 +35,6 @@ use Tests\TestCase;
*/
class AccountMetaFactoryTest extends TestCase
{
/**
*
*/
@@ -50,16 +49,17 @@ class AccountMetaFactoryTest extends TestCase
*/
public function testCreate(): void
{
$account = $this->user()->accounts()->inRandomOrder()->first();
$account = $this->getRandomAsset();
$data = [
'account_id' => $account->id,
'name' => 'Some name',
'data' => 'Some value',
];
$factory = new AccountMetaFactory;
$factory = app(AccountMetaFactory::class);
$result = $factory->create($data);
$this->assertEquals($data['name'], $result->name);
$result->forceDelete();
}
/**
@@ -67,19 +67,20 @@ class AccountMetaFactoryTest extends TestCase
*/
public function testCrudDelete(): void
{
$factory = new AccountMetaFactory;
$account = $this->user()->accounts()->inRandomOrder()->first();
$factory = app(AccountMetaFactory::class);
$account = $this->getRandomAsset();
$data = [
'account_id' => $account->id,
'name' => 'Some name ' . random_int(1, 100000),
'name' => sprintf('Some name %d', $this->randomInt()),
'data' => 'Some value',
];
$factory->create($data);
$new = $factory->create($data);
// update existing one
$result = $factory->crud($account, $data['name'], '');
$this->assertNull($result);
$this->assertCount(0, AccountMeta::where('id', $new->id)->get());
}
/**
@@ -87,11 +88,11 @@ class AccountMetaFactoryTest extends TestCase
*/
public function testCrudExisting(): void
{
$factory = new AccountMetaFactory;
$account = $this->user()->accounts()->inRandomOrder()->first();
$factory = app(AccountMetaFactory::class);
$account = $this->getRandomAsset();
$data = [
'account_id' => $account->id,
'name' => 'Some name ' . random_int(1, 100000),
'name' => sprintf('Some name %d', $this->randomInt()),
'data' => 'Some value',
];
@@ -103,7 +104,6 @@ class AccountMetaFactoryTest extends TestCase
$this->assertEquals($result->account_id, $account->id);
$this->assertEquals($existing->name, $result->name);
$this->assertEquals('Some NEW value', $result->data);
}
/**
@@ -111,9 +111,9 @@ class AccountMetaFactoryTest extends TestCase
*/
public function testCrudNew(): void
{
$account = $this->user()->accounts()->inRandomOrder()->first();
$factory = new AccountMetaFactory;
$result = $factory->crud($account, 'random name ' . random_int(1, 100000), 'Some value');
$factory = app(AccountMetaFactory::class);
$account = $this->getRandomAsset();
$result = $factory->crud($account, 'random name ' . $this->randomInt(), 'Some value');
$this->assertNotNull($result);
$this->assertEquals($result->account_id, $account->id);