Improve test coverage.

2026-01-09 20:11:22 +00:00 · 2019-06-13 06:39:05 +02:00
parent 6fdfa722dd
commit aacd218056
13 changed files with 1204 additions and 591 deletions
--- a/tests/Unit/Console/Commands/Upgrade/MigrateJournalNotesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/MigrateJournalNotesTest.php
@@ -0,0 +1,94 @@
+<?php
+/**
+ * MigrateJournalNotesTest.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace Tests\Unit\Console\Commands\Upgrade;
+
+
+use FireflyConfig;
+use FireflyIII\Models\Configuration;
+use FireflyIII\Models\TransactionJournalMeta;
+use Log;
+use Tests\TestCase;
+
+/**
+ * Class MigrateJournalNotesTest
+ */
+class MigrateJournalNotesTest extends TestCase
+{
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::info(sprintf('Now in %s.', get_class($this)));
+    }
+
+    /**
+     * @covers \FireflyIII\Console\Commands\Upgrade\MigrateJournalNotes
+     */
+    public function testHandle(): void
+    {
+        $false       = new Configuration;
+        $false->data = false;
+        FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_notes', false])->andReturn($false);
+        FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_notes', true]);
+
+        // assume all is well.
+        $this->artisan('firefly-iii:migrate-notes')
+             ->expectsOutput('No notes to migrate.')
+             ->assertExitCode(0);
+    }
+
+    /**
+     * @covers \FireflyIII\Console\Commands\Upgrade\MigrateJournalNotes
+     */
+    public function testHandleNote(): void
+    {
+        $false       = new Configuration;
+        $false->data = false;
+        FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_notes', false])->andReturn($false);
+        FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_notes', true]);
+
+        $journal = $this->getRandomWithdrawal();
+        $meta    = TransactionJournalMeta::create(
+            [
+                'transaction_journal_id' => $journal->id,
+                'name'                   => 'notes',
+                'data'                   => json_encode('Some note.'),
+                'hash'                   => 'Some hash',
+            ]
+        );
+        // assume one is fixed.
+        $this->artisan('firefly-iii:migrate-notes')
+             ->expectsOutput('Migrated 1 note(s).')
+             ->assertExitCode(0);
+
+        $this->assertCount(0, TransactionJournalMeta
+            ::where('name', 'notes')
+            ->where('id', $meta->id)
+            ->whereNull('deleted_at')
+            ->get());
+
+    }
+
+
+}