From abfa2af278f54dea64ae248f7779bf0943f5b2c1 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 11 Nov 2025 06:16:36 +0100 Subject: [PATCH] Expand tests. --- .../workflows/issues-reply-old-versions.yml | 47 +++++++++++++++++-- 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/.github/workflows/issues-reply-old-versions.yml b/.github/workflows/issues-reply-old-versions.yml index 5bb9362a57..4fe3f005eb 100644 --- a/.github/workflows/issues-reply-old-versions.yml +++ b/.github/workflows/issues-reply-old-versions.yml @@ -31,6 +31,8 @@ jobs: excludes: prerelease, draft token: ${{ secrets.GITHUB_TOKEN }} - run: | + ISSUE_BODY=$(gh issue view $NUMBER --json body) + # sure this can be done in a single step but still. FFNOV="${{ steps.ff3version.outputs.release }}" FFNOV="${FFNOV:1}" @@ -38,10 +40,26 @@ jobs: DDNOV="${{ steps.importerversion.outputs.release }}" DDNOV="${DDNOV:1}" - echo "Version is ${{ steps.ff3version.outputs.release }}, without v is $FFNOV" + echo "Firefly III version is ${{ steps.ff3version.outputs.release }}, without v is $FFNOV" + echo "Data importer version is ${{ steps.ff3version.outputs.release }}, without v is $FFNOV" + + # first test: no debug info OR old version for issue type BUG + if [[ $ISSUE_BODY == *"MZ2udTpin6FL"* && $ISSUE_BODY != *"Debug information generated at"* ]]; then + MESSAGE="Hi there! - ISSUE_BODY=$(gh issue view $NUMBER --json body) - if [[ $ISSUE_BODY == *"MZ2udTpin6FL"* && $ISSUE_BODY != *${{ steps.ff3version.outputs.release }}* && $ISSUE_BODY != *${{ steps.importerversion.outputs.release }}* && $ISSUE_BODY != *$FFNOV* && $ISSUE_BODY != *$DDNOV* ]]; then + This is an automated reply. \`Share and enjoy\` + + You triggered an automated reply, because it looks like you didn't include the output from the `/debug` page. Would you be so kind as to do that? It helps the developers debug your issue more easily. + + If you did include debug information, and this message is wrong, my apologies for the intrusion." + + gh issue comment "$NUMBER" --body "$MESSAGE" + echo "Triggered on first test" + exit 0 + fi + + # second test: no debug info + old version for issue type BUG + if [[ $ISSUE_BODY == *"MZ2udTpin6FL"* && $ISSUE_BODY != *"Debug information generated at"* && $ISSUE_BODY != *${{ steps.ff3version.outputs.release }}* && $ISSUE_BODY != *${{ steps.importerversion.outputs.release }}* && $ISSUE_BODY != *$FFNOV* && $ISSUE_BODY != *$DDNOV* ]]; then MESSAGE="Hi there! @@ -51,8 +69,29 @@ jobs: Please be so kind as to include the output from the \`/debug\`-page, if you have not done so already. If you already included the debug information, please make sure to upgrade to the latest version of Firefly III (or the data importer) *first*. This may already solve your issue. - If you are running the latest version, and this message is wrong, my apologies for the intrusion." + If you *are* running the latest version, and this message is wrong, my apologies for the intrusion." + gh issue comment "$NUMBER" --body "$MESSAGE" + echo "Triggered on second test" + exit 0 + fi + + # third test: debug info but old version + if [[ $ISSUE_BODY == *"MZ2udTpin6FL"* && $ISSUE_BODY == *"Debug information generated at"* && $ISSUE_BODY != *${{ steps.ff3version.outputs.release }}* && $ISSUE_BODY != *${{ steps.importerversion.outputs.release }}* && $ISSUE_BODY != *$FFNOV* && $ISSUE_BODY != *$DDNOV* ]]; then + + MESSAGE="Hi there! + + This is an automated reply. \`Share and enjoy\` + + You triggered an automated reply, because it looks like you're not running Firefly III version **${{ steps.ff3version.outputs.release }}** or version **${{ steps.importerversion.outputs.release }}** of the data importer. + + Please make sure to upgrade to the latest version of Firefly III (or the data importer) *first*. This may already solve your issue. + + If you are running the latest version, and this message is wrong, my apologies for the intrusion." + + gh issue comment "$NUMBER" --body "$MESSAGE" + echo "Triggered on third test" + exit 0 fi env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}