gh-mirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-10 12:24:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2018-07-08 12:08:53 +02:00
parent 2f2f907ffe
commit b315882f58
56 changed files with 465 additions and 396 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Http/Controllers/Json/AutoCompleteController.php
View File

@@ -160,6 +160,7 @@ class AutoCompleteController extends Controller
return response()->json($return);
}
/**
* @param JournalCollectorInterface $collector
* @param TransactionJournal $except

4
app/Http/Controllers/Json/BoxController.php
View File

@@ -41,6 +41,7 @@ use FireflyIII\Support\CacheProperties;
*/
class BoxController extends Controller
{
/**
* @param BudgetRepositoryInterface $repository
*
@@ -92,6 +93,7 @@ class BoxController extends Controller
return response()->json($return);
}
/**
* @param CurrencyRepositoryInterface $repository
*
@@ -173,6 +175,7 @@ class BoxController extends Controller
return response()->json($response);
}
/**
* @param BillRepositoryInterface $repository
*
@@ -208,6 +211,7 @@ class BoxController extends Controller
return response()->json($return);
}
/**
* @param AccountRepositoryInterface $repository
*

1
app/Http/Controllers/Json/ExchangeController.php
View File

@@ -35,6 +35,7 @@ use Log;
*/
class ExchangeController extends Controller
{
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* @param Request $request
* @param TransactionCurrency $fromCurrency

29
app/Http/Controllers/Json/IntroController.php
View File

@@ -31,16 +31,15 @@ use Log;
class IntroController
{
/**
* Get the intro steps. There are currently no specific routes with an outro step.
*
* @param string $route
* @param string $specificPage
* @param string $route
* @param string|null $specificPage
*
* @return \Illuminate\Http\JsonResponse
*/
public function getIntroSteps(string $route, string $specificPage = '')
public function getIntroSteps(string $route, string $specificPage = null)
{
Log::debug(sprintf('getIntroSteps for route "%s" and page "%s"', $route, $specificPage));
$specificPage = $specificPage ?? '';
$steps = $this->getBasicSteps($route);
$specificSteps = $this->getSpecificSteps($route, $specificPage);
if (0 === \count($specificSteps)) {
@@ -90,15 +89,16 @@ class IntroController
}
/**
* @param string $route
* @param string $specialPage
* @param string $route
* @param string|null $specialPage
*
* @return \Illuminate\Http\JsonResponse
*/
public function postEnable(string $route, string $specialPage = '')
public function postEnable(string $route, string $specialPage = null)
{
$route = str_replace('.', '_', $route);
$key = 'shown_demo_' . $route;
$specialPage = $specialPage ?? '';
$route = str_replace('.', '_', $route);
$key = 'shown_demo_' . $route;
if ('' !== $specialPage) {
$key .= '_' . $specialPage;
}
@@ -109,14 +109,15 @@ class IntroController
}
/**
* @param string $route
* @param string $specialPage
* @param string $route
* @param string|null $specialPage
*
* @return \Illuminate\Http\JsonResponse
*/
public function postFinished(string $route, string $specialPage = '')
public function postFinished(string $route, string $specialPage = null)
{
$key = 'shown_demo_' . $route;
$specialPage = $specialPage ?? '';
$key = 'shown_demo_' . $route;
if ('' !== $specialPage) {
$key .= '_' . $specialPage;
}