Ignore basic methods, improving code coverage.

This commit is contained in:
James Cole
2018-06-02 06:18:07 +02:00
parent ddc1d81665
commit ba01c4bbe8
22 changed files with 104 additions and 89 deletions

View File

@@ -51,7 +51,7 @@ class CreateTokenRequest extends SpectreRequest
$data = [
'data' => [
'customer_id' => $this->customer->getId(),
'fetch_scopes' => ['accounts', 'transactions'],
'fetch_scopes' => ['accounts', 'transactions'],
'daily_refresh' => true,
'include_fake_providers' => true,
'show_consent_confirmation' => true,

View File

@@ -24,7 +24,6 @@ declare(strict_types=1);
namespace FireflyIII\Services\Spectre\Request;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Services\Spectre\Exception\SpectreException;
use FireflyIII\Services\Spectre\Object\Account;
use FireflyIII\Services\Spectre\Object\Login;
use Log;

View File

@@ -72,7 +72,7 @@ class ListLoginsRequest extends SpectreRequest
$collection->push(new Login($loginArray));
}
// sort logins by date created:
$sorted = $collection->sortByDesc(
$sorted = $collection->sortByDesc(
function (Login $login) {
return $login->getUpdatedAt()->timestamp;
}

View File

@@ -24,7 +24,6 @@ declare(strict_types=1);
namespace FireflyIII\Services\Spectre\Request;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Services\Spectre\Exception\SpectreException;
use FireflyIII\Services\Spectre\Object\Account;
use FireflyIII\Services\Spectre\Object\Transaction;
use Log;

View File

@@ -53,6 +53,7 @@ abstract class SpectreRequest
abstract public function call(): void;
/**
* @codeCoverageIgnore
* @return string
*/
public function getAppId(): string
@@ -61,6 +62,8 @@ abstract class SpectreRequest
}
/**
* @codeCoverageIgnore
*
* @param string $appId
*/
public function setAppId(string $appId): void
@@ -69,6 +72,7 @@ abstract class SpectreRequest
}
/**
* @codeCoverageIgnore
* @return string
*/
public function getSecret(): string
@@ -77,6 +81,8 @@ abstract class SpectreRequest
}
/**
* @codeCoverageIgnore
*
* @param string $secret
*/
public function setSecret(string $secret): void
@@ -85,6 +91,7 @@ abstract class SpectreRequest
}
/**
* @codeCoverageIgnore
* @return string
*/
public function getServer(): string
@@ -93,6 +100,8 @@ abstract class SpectreRequest
}
/**
* @codeCoverageIgnore
*
* @param string $privateKey
*/
public function setPrivateKey(string $privateKey): void