diff --git a/app/Http/Controllers/Export/IndexController.php b/app/Http/Controllers/Export/IndexController.php index 09d67a73f0..4f12a6815e 100644 --- a/app/Http/Controllers/Export/IndexController.php +++ b/app/Http/Controllers/Export/IndexController.php @@ -41,8 +41,7 @@ use League\Csv\CannotInsertRecord; class IndexController extends Controller { - /** @var JournalRepositoryInterface */ - private $journalRepository; + private JournalRepositoryInterface $journalRepository; /** * IndexController constructor. diff --git a/app/Http/Controllers/Rule/EditController.php b/app/Http/Controllers/Rule/EditController.php index 5f842af2d3..55f6a561c6 100644 --- a/app/Http/Controllers/Rule/EditController.php +++ b/app/Http/Controllers/Rule/EditController.php @@ -37,6 +37,8 @@ use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; use Illuminate\Routing\Redirector; use Illuminate\View\View; +use Throwable; +use Log; /** * Class EditController @@ -45,8 +47,7 @@ class EditController extends Controller { use RuleManagement, RenderPartialViews; - /** @var RuleRepositoryInterface Rule repository */ - private $ruleRepos; + private RuleRepositoryInterface $ruleRepos; /** * RuleController constructor. diff --git a/app/Services/Password/PwndVerifierV2.php b/app/Services/Password/PwndVerifierV2.php index 18c300e572..a5588f0b5b 100644 --- a/app/Services/Password/PwndVerifierV2.php +++ b/app/Services/Password/PwndVerifierV2.php @@ -53,6 +53,7 @@ class PwndVerifierV2 implements Verifier */ public function validPassword(string $password): bool { + // Yes SHA1 is unsafe but in this context its fine. $hash = sha1($password); $prefix = substr($hash, 0, 5); $rest = substr($hash, 5);