gh-mirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-09 20:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Give commands proper exit codes.

Browse Source
This commit is contained in:
James Cole
2018-07-22 10:05:06 +02:00
parent 1f0fdf3da7
commit d193a6aec4
6 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Console/Commands/Import.php
View File

@@ -59,7 +59,7 @@ class Import extends Command
*
* @throws FireflyException
*/
public function handle(): void
public function handle(): int
{
Log::debug('Start start-import command');
$jobKey = $this->argument('key');
@@ -67,12 +67,12 @@ class Import extends Command
if (null === $job) {
$this->errorLine(sprintf('No job found with key "%s"', $jobKey));
return;
return 1;
}
if (!$this->isValid($job)) {
$this->errorLine('Job is not valid for some reason. Exit.');
return;
return 1;
}
$this->infoLine(sprintf('Going to import job with key "%s" of type "%s"', $job->key, $job->file_type));
@@ -106,6 +106,8 @@ class Import extends Command
}
$this->infoLine(sprintf('The import has finished. %d transactions have been imported.', $count));
return 0;
}
/**