From dc1ecf6a42d8a03c8d5e5bf931d492181e3dd9a1 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 3 Nov 2024 07:43:55 +0100 Subject: [PATCH] Fix https://github.com/firefly-iii/firefly-iii/issues/9389 --- app/Services/Internal/Support/RecurringTransactionTrait.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/Services/Internal/Support/RecurringTransactionTrait.php b/app/Services/Internal/Support/RecurringTransactionTrait.php index 443448e330..941e5ddc73 100644 --- a/app/Services/Internal/Support/RecurringTransactionTrait.php +++ b/app/Services/Internal/Support/RecurringTransactionTrait.php @@ -40,6 +40,7 @@ use FireflyIII\Models\RecurrenceTransaction; use FireflyIII\Models\RecurrenceTransactionMeta; use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\Validation\AccountValidator; +use Illuminate\Support\Facades\Log; /** * Trait RecurringTransactionTrait @@ -212,10 +213,13 @@ trait RecurringTransactionTrait private function setBudget(RecurrenceTransaction $transaction, int $budgetId): void { + Log::debug(sprintf('Now in %s', __METHOD__)); $budgetFactory = app(BudgetFactory::class); $budgetFactory->setUser($transaction->recurrence->user); $budget = $budgetFactory->find($budgetId, null); if (null === $budget) { + // remove budget from recurring transaction: + $transaction->recurrenceTransactionMeta()->where('name', 'budget_id')->delete(); return; } @@ -235,6 +239,8 @@ trait RecurringTransactionTrait $billFactory->setUser($transaction->recurrence->user); $bill = $billFactory->find($billId, null); if (null === $bill) { + // remove bill from recurring transaction: + $transaction->recurrenceTransactionMeta()->where('name', 'bill_id')->delete(); return; }