From dd4158c6b47b20fad2bb695881985fa7394f97c9 Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 29 Jan 2018 19:09:00 +0100 Subject: [PATCH] Expand tests --- .../Controllers/AttachmentControllerTest.php | 50 ++++++++++++------- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/tests/Feature/Controllers/AttachmentControllerTest.php b/tests/Feature/Controllers/AttachmentControllerTest.php index ba7eaa8de5..34c8282e13 100644 --- a/tests/Feature/Controllers/AttachmentControllerTest.php +++ b/tests/Feature/Controllers/AttachmentControllerTest.php @@ -119,23 +119,6 @@ class AttachmentControllerTest extends TestCase $response->assertSee('
    '); } - /** - * @covers \FireflyIII\Http\Controllers\AttachmentController::preview - * @covers \FireflyIII\Http\Controllers\AttachmentController::__construct - */ - public function testView() - { - $repository = $this->mock(AttachmentRepositoryInterface::class); - $repository->shouldReceive('exists')->once()->andReturn(true); - $repository->shouldReceive('getContent')->once()->andReturn('This is attachment number one.'); - - $journalRepos = $this->mock(JournalRepositoryInterface::class); - $journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal); - $this->be($this->user()); - $response = $this->get(route('attachments.view', [3])); - $response->assertStatus(200); - } - /** * @covers \FireflyIII\Http\Controllers\AttachmentController::update */ @@ -159,4 +142,37 @@ class AttachmentControllerTest extends TestCase $response->assertStatus(302); $response->assertSessionHas('success'); } + + /** + * @covers \FireflyIII\Http\Controllers\AttachmentController::view + * @covers \FireflyIII\Http\Controllers\AttachmentController::__construct + */ + public function testView() + { + $repository = $this->mock(AttachmentRepositoryInterface::class); + $repository->shouldReceive('exists')->once()->andReturn(true); + $repository->shouldReceive('getContent')->once()->andReturn('This is attachment number one.'); + + $journalRepos = $this->mock(JournalRepositoryInterface::class); + $journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal); + $this->be($this->user()); + $response = $this->get(route('attachments.view', [3])); + $response->assertStatus(200); + } + + /** + * @covers \FireflyIII\Http\Controllers\AttachmentController::view + * @covers \FireflyIII\Http\Controllers\AttachmentController::__construct + */ + public function testViewFail() + { + $repository = $this->mock(AttachmentRepositoryInterface::class); + $repository->shouldReceive('exists')->once()->andReturn(false); + + $journalRepos = $this->mock(JournalRepositoryInterface::class); + $journalRepos->shouldReceive('first')->once()->andReturn(new TransactionJournal); + $this->be($this->user()); + $response = $this->get(route('attachments.view', [1])); + $response->assertStatus(500); + } }