Various fixes for tests and code quality.

This commit is contained in:
James Cole
2018-07-20 20:53:48 +02:00
parent 49ff6febe5
commit ec7ef3a813
28 changed files with 79 additions and 50 deletions

View File

@@ -45,15 +45,15 @@ use Log;
*/
class ReconcileController extends Controller
{
/** @var AccountRepositoryInterface */
/** @var AccountRepositoryInterface The account repository */
private $accountRepos;
/** @var CurrencyRepositoryInterface */
/** @var CurrencyRepositoryInterface The currency repository */
private $currencyRepos;
/** @var JournalRepositoryInterface */
/** @var JournalRepositoryInterface Journals and transactions overview */
private $repository;
/**
*
* ReconcileController constructor.
*/
public function __construct()
{
@@ -74,6 +74,8 @@ class ReconcileController extends Controller
}
/**
* Edit a reconciliation.
*
* @param TransactionJournal $journal
*
* @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
@@ -110,6 +112,8 @@ class ReconcileController extends Controller
}
/**
* Reconciliation overview.
*
* @param Account $account
* @param Carbon|null $start
* @param Carbon|null $end
@@ -168,6 +172,8 @@ class ReconcileController extends Controller
}
/**
* Show a single reconciliation.
*
* @param TransactionJournal $journal
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Illuminate\View\View
@@ -193,6 +199,8 @@ class ReconcileController extends Controller
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Submit a new reconciliation.
*
* @param ReconciliationStoreRequest $request
* @param Account $account
* @param Carbon $start
@@ -278,6 +286,8 @@ class ReconcileController extends Controller
/**
* Update a reconciliation.
*
* @param ReconciliationUpdateRequest $request
* @param TransactionJournal $journal
*
@@ -359,6 +369,8 @@ class ReconcileController extends Controller
}
/**
* Redirect user to the original asset account.
*
* @param Account $account
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector