gh-mirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-09 20:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-04-07 07:28:43 +02:00
parent 4ddcb0c965
commit f12744ad8c
180 changed files with 714 additions and 721 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/Http/Controllers/Transaction/MassController.php
View File

@@ -168,7 +168,7 @@ class MassController extends Controller
$journalIds = $request->get('journals');
if (!is_array($journalIds)) {
// TODO something error.
throw new FireflyException('This is not an array.'); // @codeCoverageIgnore
throw new FireflyException('This is not an array.');
}
$count = 0;
/** @var string $journalId */
@@ -177,8 +177,8 @@ class MassController extends Controller
try {
$this->updateJournal($integer, $request);
$count++;
} catch (FireflyException $e) { // @codeCoverageIgnore
// do something with error.
} catch (FireflyException $e) {
// @ignoreException
}
}
@@ -199,7 +199,7 @@ class MassController extends Controller
{
$journal = $this->repository->findNull($journalId);
if (null === $journal) {
throw new FireflyException(sprintf('Trying to edit non-existent or deleted journal #%d', $journalId)); // @codeCoverageIgnore
throw new FireflyException(sprintf('Trying to edit non-existent or deleted journal #%d', $journalId));
}
$service = app(JournalUpdateService::class);
// for each field, call the update service.
@@ -240,7 +240,7 @@ class MassController extends Controller
if (!is_array($value)) {
return null;
}
if (!isset($value[$journalId])) {
if (!array_key_exists($journalId, $value)) {
return null;
}
try {
@@ -268,7 +268,7 @@ class MassController extends Controller
if (!is_array($value)) {
return null;
}
if (!isset($value[$journalId])) {
if (!array_key_exists($journalId, $value)) {
return null;
}
@@ -289,7 +289,7 @@ class MassController extends Controller
if (!is_array($value)) {
return null;
}
if (!isset($value[$journalId])) {
if (!array_key_exists($journalId, $value)) {
return null;
}