gh-mirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-23 19:51:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed for-loop in favour of "pluck()" aka: RTFM.

Browse Source
This commit is contained in:
James Cole
2015-12-30 09:17:14 +01:00
parent 9f87890ead
commit f99e46bf75
2 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Repositories/Category/SingleCategoryRepository.php
View File

@@ -110,10 +110,7 @@ class SingleCategoryRepository extends ComponentRepository implements SingleCate
*/ */
public function earnedInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end) public function earnedInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end)
{ {
$accountIds = []; $accountIds = $accounts->pluck('id')->toArray();
foreach ($accounts as $account) {
$accountIds[] = $account->id;
}
$sum $sum
= $category = $category
->transactionjournals() ->transactionjournals()
@@ -237,10 +234,7 @@ class SingleCategoryRepository extends ComponentRepository implements SingleCate
*/ */
public function spentInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end) public function spentInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end)
{ {
$accountIds = []; $accountIds = $accounts->pluck('id')->toArray();
foreach ($accounts as $account) {
$accountIds[] = $account->id;
}
$sum $sum
= $category = $category

6
app/Repositories/Shared/ComponentRepository.php
View File

@@ -39,11 +39,7 @@ class ComponentRepository
return $cache->get(); // @codeCoverageIgnore return $cache->get(); // @codeCoverageIgnore
} }
$ids = []; $ids = $accounts->pluck('id')->toArray();
/** @var Account $account */
foreach ($accounts as $account) {
$ids[] = $account->id;
}
$entry = $object->transactionjournals() $entry = $object->transactionjournals()