From 8efc998687122ee54c2b94844321f09c38e93ddb Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Mon, 8 Dec 2025 15:53:10 -0800 Subject: [PATCH] Chore: refactor permission checks to use queryset.exists() --- src/documents/permissions.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/documents/permissions.py b/src/documents/permissions.py index cf6a9aa35..802cb8798 100644 --- a/src/documents/permissions.py +++ b/src/documents/permissions.py @@ -85,12 +85,12 @@ def set_permissions_for_object(permissions: list[str], object, *, merge: bool = if not merge else User.objects.none() ) - if len(users_to_add) > 0 and len(users_to_remove) > 0: + if users_to_add.exists() and users_to_remove.exists(): users_to_remove = users_to_remove.exclude(id__in=users_to_add) - if len(users_to_remove) > 0: + if users_to_remove.exists(): for user in users_to_remove: remove_perm(permission, user, object) - if len(users_to_add) > 0: + if users_to_add.exists(): for user in users_to_add: assign_perm(permission, user, object) if action == "change": @@ -111,12 +111,12 @@ def set_permissions_for_object(permissions: list[str], object, *, merge: bool = if not merge else Group.objects.none() ) - if len(groups_to_add) > 0 and len(groups_to_remove) > 0: + if groups_to_add.exists() and groups_to_remove.exists(): groups_to_remove = groups_to_remove.exclude(id__in=groups_to_add) - if len(groups_to_remove) > 0: + if groups_to_remove.exists(): for group in groups_to_remove: remove_perm(permission, group, object) - if len(groups_to_add) > 0: + if groups_to_add.exists(): for group in groups_to_add: assign_perm(permission, group, object) if action == "change":