gh-mirrors/openwrt-packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2025-12-10 12:41:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

ddns-scripts: refactor update_url checks to avoid echo|grep sub-shells

Browse Source 
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
This commit is contained in:
Paul Donald
2024-11-27 20:39:00 +01:00
committed by Florian Eckert
parent 6706a5bd78
commit 91954f4b69
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh
View File

@@ -266,16 +266,16 @@ esac
[ -n "$update_url" ] && {
# only check if update_url is given, update_scripts have to check themselves
[ -z "$domain" ] && $(echo "$update_url" | grep "\[DOMAIN\]" >/dev/null 2>&1) && \
write_log 14 "Service section not configured correctly! Missing 'domain'"
[ -z "$username" ] && $(echo "$update_url" | grep "\[USERNAME\]" >/dev/null 2>&1) && \
write_log 14 "Service section not configured correctly! Missing 'username'"
[ -z "$password" ] && $(echo "$update_url" | grep "\[PASSWORD\]" >/dev/null 2>&1) && \
write_log 14 "Service section not configured correctly! Missing 'password'"
[ -z "$param_enc" ] && $(echo "$update_url" | grep "\[PARAMENC\]" >/dev/null 2>&1) && \
write_log 14 "Service section not configured correctly! Missing 'param_enc'"
[ -z "$param_opt" ] && $(echo "$update_url" | grep "\[PARAMOPT\]" >/dev/null 2>&1) && \
write_log 14 "Service section not configured correctly! Missing 'param_opt'"
[ -z "$domain" ] && [ "${update_url##*'[DOMAIN]'}" != "$update_url" ] && \
write_log 14 "Service section missing 'domain'"
[ -z "$username" ] && [ "${update_url##*'[USERNAME]'}" != "$update_url" ] && \
write_log 14 "Service section missing 'username'"
[ -z "$password" ] && [ "${update_url##*'[PASSWORD]'}" != "$update_url" ] && \
write_log 14 "Service section missing 'password'"
[ -z "$param_enc" ] && [ "${update_url##*'[PARAMENC]'}" != "$update_url" ] && \
write_log 14 "Service section missing 'param_enc'"
[ -z "$param_opt" ] && [ "${update_url##*'[PARAMOPT]'}" != "$update_url" ] && \
write_log 14 "Service section missing 'param_opt'"
}
# verify ip_source 'script' if script is configured and executable